Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add thread names to rayon thread pool #15024

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

trueb2
Copy link
Contributor

@trueb2 trueb2 commented Mar 12, 2024

This adds names to the threads in the Rayon thread pool. They are configurable via the POLARS_THREAD_NAME environment variable and default to polars-{thread_idx}.

Example without and with the change:

Screenshot 2024-03-12 at 4 48 03 PM Screenshot 2024-03-12 at 5 15 57 PM

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (e7be629) to head (c3d7169).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15024      +/-   ##
==========================================
+ Coverage   80.98%   80.99%   +0.01%     
==========================================
  Files        1333     1337       +4     
  Lines      173141   173313     +172     
  Branches     2458     2460       +2     
==========================================
+ Hits       140217   140378     +161     
- Misses      32456    32466      +10     
- Partials      468      469       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Wow! I like that!

@ritchie46 ritchie46 merged commit edd267e into pola-rs:main Mar 13, 2024
19 checks passed
@trueb2 trueb2 deleted the user/jtrueb/thread-names branch March 13, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants